21537 - Shortname Refunds - PATCH / GET methods & Notification #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
seeker25
commented
Sep 20, 2024
|
Looks good so far! Thanks! |
ochiu
reviewed
Sep 20, 2024
ochiu
approved these changes
Sep 20, 2024
Jxio
approved these changes
Sep 20, 2024
seeker25
commented
Sep 20, 2024
seeker25
commented
Sep 20, 2024
seeker25
changed the title
|
Need the notification too haha |
seeker25
changed the title
seeker25
commented
Sep 23, 2024
| @@ -80,5 +80,6 @@ def get_eft_credits(cls, short_name_id: int) -> List[Self]: | |||
| return (cls.query | |||
| .filter(EFTCredit.remaining_amount > 0) | |||
| .filter(EFTCredit.short_name_id == short_name_id) | |||
| .with_for_update() | |||
seeker25
changed the title
…abase instead, rename REJECTED - >DECLINED so it matches business verbage, build serializable base class to assist with ATTRS serialization
seeker25
commented
Sep 24, 2024
rodrigo-barraza
approved these changes
Sep 24, 2024
ochiu
reviewed
Sep 25, 2024
| """Retrieve emails with the specified keycloak role.""" | ||
| users = get_users_with_keycloak_role(role) | ||
| # Purpose of this is so our TEST users don't get hammered with emails, also our tester can easily switch this on. | ||
| if override_emails := flags.is_on('override-eft-refund-emails', default=False): |
ochiu
reviewed
Sep 25, 2024
ochiu
approved these changes
Sep 25, 2024
|
Looks good, just the one comment about the history. I have also merged a PR with a fix to the tests, sorry that was my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#21537
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).